Skip to content

RI-7540: update key name text input styles #5011

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Oct 1, 2025
Merged

RI-7540: update key name text input styles #5011

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
a7db714
RI-7552: close popover on escape press
KrumTy Sep 29, 2025
18c33f1
RI-7552: unfocus input on esc press
KrumTy Sep 29, 2025
283bf7d
RI-7540: update key name text input styles
KrumTy Sep 30, 2025
c97b5e9
Merge remote-tracking branch 'origin/main' into fe/bugfix/RI-7540/key…
KrumTy Sep 30, 2025
fb4ae7f
RI-7540: grow input field
KrumTy Sep 30, 2025
4251d82
use flex item grow
KrumTy Sep 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions ...er/modules/key-details-header/components/key-details-header-name/KeyDetailsHeaderName.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,15 +147,12 @@ const KeyDetailsHeaderName = ({ onEditKey }: Props) => {

return (
<FlexItem
grow
grow={5}
direction="row"
onMouseEnter={onMouseEnterKey}
onMouseLeave={onMouseLeaveKey}
onClick={onClickKey}
className={cx(
styles.keyFlexItem, // TODO with styles.keyFlexItemEditing
keyIsEditing || keyIsHovering ? styles.keyFlexItemEditing : null,
)}
$gap="xs"
data-testid="edit-key-btn"
>
{keyIsEditing || keyIsHovering ? (
Expand Down
2 changes: 2 additions & 0 deletions .../browser/modules/key-details-header/components/key-details-header-name/styles.module.scss
View file
Open in desktop
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should try to get rid of scss - move to single css solution - rather than adding to it

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I brought the class name and style that was removed with the previous file commit

now removed in favor of grow prop

Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
.toolTipAnchorKey {
max-width: 450px;
height: 31px !important;
width: 100%;
}

.keyInput {
Expand All @@ -21,6 +22,7 @@
white-space: nowrap;
overflow: hidden;
text-overflow: ellipsis;
padding-right: 6px;
}

:global(.browserPage .key-details-header .euiFormControlLayout) {
Expand Down
Loading