Skip to content

Conversation

valkirilov
Copy link
Member

Description

Rename "Saved queries" to "Sample queries" everywhere in the new Search page

  • button in the top right corner used to open the respective panel
  • title of the panel
  • fallback message when there is no data
image

How it was tested

Manually

  1. Open the Databases page and connect to an existing database (or establish a connection with a new instance)
  2. Go to the Search tab from the main navbar
  3. Open the Sample Queries panel from the top right corner

Automatically via e2e tests

You can always refer to the README, but simply running the following commands should do the trick for you

# From the root directory
yarn dev:api

# In a new tab, again from the root directory
yarn dev:ui

# In a new tab, but this time go to tests/playwright directory
yarn test:chromium:local-web vector-search/saved-queries

# Then, check the detailed report and all the video recordings
yarn playwright show-report
image

Copy link
Contributor

github-actions bot commented Oct 1, 2025

Code Coverage - Frontend unit tests

St.
Category Percentage Covered / Total
🟢 Statements 82.15% 20027/24379
🟡 Branches 67.47% 8680/12865
🟡 Functions 76.3% 5332/6988
🟢 Lines 82.57% 19607/23746

Test suite run success

5162 tests passing in 677 suites.

Report generated by 🧪jest coverage report action from 767b382

// Ensure the queries are displayed
await expect(searchPage.savedQueriesContainer).toContainText(
'Search for "Nord" bikes ordered by price', // TODO: Replace this with actual query, once we reimplement them soon
"Run a vector search for 'Comfortable commuter bike'", // TODO: Replace this with actual query, once we reimplement them soon
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, can we drop the comment?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer to keep it for now, because in the second iteration, we plan to add CRUD for these saved queries, and ideally, we should check not for the hardcoded queries, but for the actual queries.

@valkirilov valkirilov merged commit 0d5472c into main Oct 2, 2025
18 checks passed
@valkirilov valkirilov deleted the fe/feature/RI-7573_sample-queries branch October 2, 2025 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants