Skip to content

Conversation

pd-redis
Copy link
Collaborator

This pull request fixes inconsistent behavior of infinite notifications, introduces comprehensive Storybook stories for the Notifications component, enabling easier testing and visualization of error, infinite, and message notifications.

Storybook Stories for Notifications

  • Added ErrorNotifications.stories.tsx with interactive buttons to trigger various error notifications for manual testing and demonstration.
  • Added InfiniteNotifications.stories.tsx to showcase infinite (ongoing) notifications, covering scenarios like authentication, database creation, and app updates.
  • Added MessageNotifications.stories.tsx to demonstrate success and informational message notifications, including bulk actions, key operations, and library management.

Component Improvements

  • refactored different notification types in separate hook files
  • ensure that only one infinite notification of certain type is shown at a time

Remove unused styles

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
3 out of 4 committers have signed the CLA.

✅ dantovska
✅ KrumTy
✅ pd-redis
❌ Kristiyan Ivanov


Kristiyan Ivanov seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@pd-redis
Copy link
Collaborator Author

Ignore the huge number of files, this PR depends on #5062 to be merged first

@pd-redis pd-redis changed the base branch from main to playground October 17, 2025 06:43
@valkirilov
Copy link
Member

I don't see clear retro steps and expected behavior either in the ticket and here in the pull request description, so maybe I didn't test it the way it should.

But based on the info in the ticket, I'm not sure whether it's working fine or not, because I see stacked notifications when I create a free cloud database.

Previous messages are not closed when creating a free Cloud db
Messages describing steps are not automatically closed when the step is completed.

  1. Go to the Databases tab
  2. Click on the "+ Add Redis Database" button
  3. Click on the "New database" box
  4. Click "Confirm" in the modal and wait for the database to be created

For some time, I see the same notification twice (see "Processing Cloud API keys"
Screenshot 2025-10-17 at 13 49 25

Then, after clicking the "Create" button to initiate the process, I still see the previous toasts
Screenshot 2025-10-17 at 13 49 43

And these toast stay forever, until I close them.
Screenshot 2025-10-17 at 13 50 07

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants