-
Notifications
You must be signed in to change notification settings - Fork 255
DOC-5711 DOC-5712 DOC-5713 DOC-5714 DOC-5716 Seamless client experience docs #2120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally LGTM. Answers:
- "SCE" seems a good abbreviation to use, but I've not officially seen it anywhere. [DWD] works for me.
- Do we need docs for the CLIENT MAINT_NOTIFICATIONS command? [DWD] no such command AFAIK.
@dwdougherty Thanks for the review! I'm not sure if the command is actually useful from the CLI, so we might not end up documenting it. |
. | ||
``` | ||
|
||
{{< note >}}SCE requires the [RESP3]({{< relref "/develop/reference/protocol-spec#resp-versions" >}}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we need to frame it like this since Lettuce tries to use RESP3 by default and falls back to RESP2 if it's not available. Maybe a link to the RS/Cloud docs here on SCE requirements is a better choice.
content/develop/clients/sce.md
Outdated
SCE is enabled by default on Redis Cloud, but you must enable it | ||
explicitly on Redis Enterprise servers. | ||
|
||
You must also configure SCE on the client side during connection. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We decided to enable it by default on the client side in RESP3 mode.
Co-authored-by: Igor Malinovskiy <[email protected]>
Draft of docs for Seamless client experience (aka Hitless upgrades). I believe all the clients that will initially support this are in beta versions or still in development, so things are likely to change before release.
All feedback is welcome, but a few particular things to think about are:
CLIENT MAINT_NOTIFICATIONS
command?