Skip to content

Propagate database number, user, and RedisURI into Tracing #3005

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 11, 2024
Merged

Propagate database number, user, and RedisURI into Tracing #3005

merged 4 commits into from
Oct 11, 2024

Conversation

thachlp
Copy link
Contributor

@thachlp thachlp commented Oct 3, 2024 •
edited by tishun
Loading

Closes #2232

Make sure that:

  • You have read the contribution guidelines.
  • You have created a feature request first to discuss your contribution intent. Please reference the feature request ticket number in the pull request.
  • You applied code formatting rules using the mvn formatter:format target. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.

tishun
tishun reviewed Oct 7, 2024
View reviewed changes
Copy link
Collaborator

@tishun tishun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @thachlp , thanks for the contribution!

Did you try this code out in a live environment?

@thachlp
Copy link
Contributor Author

thachlp commented Oct 7, 2024

Hey @thachlp , thanks for the contribution!

Did you try this code out in a live environment?

Not yet, I just updated to verify the update.

@thachlp thachlp requested a review from tishun October 7, 2024 12:40
@tishun tishun added the type: feature A new feature label Oct 10, 2024
@tishun tishun added this to the 6.5.0.RELEASE milestone Oct 10, 2024
@tishun tishun merged commit 542b6a5 into redis:main Oct 11, 2024
5 checks passed
thachlp added a commit to thachlp/lettuce that referenced this pull request Dec 31, 2024
@thachlp
Propagate database number, user, and RedisURI into Tracing (redis#3005)
53e6ffc 
* Propagate database number, user, and RedisURI into Tracing

* Update attribute names as recommend

* Add db.user info

* Polishing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tishun tishun tishun approved these changes

Assignees
No one assigned
Labels
type: feature A new feature
Projects
None yet
Milestone
6.5.0.RELEASE
Development

Successfully merging this pull request may close these issues.

Propagate database number, user, and RedisURI into Tracing
2 participants
@thachlp @tishun