Skip to content

Conversation

ggivo
Copy link
Contributor

@ggivo ggivo commented Oct 30, 2024

Using custom credentials provider can delay providing credentials. In this case applyPostHandshake and applyConnectionMetadata got executed before handshake and led to a NOAUTH error in the log for CLIENT command.
Closes #2996

Make sure that:

  • You have read the contribution guidelines.
  • You have created a feature request first to discuss your contribution intent. Please reference the feature request ticket number in the pull request.
  • You applied code formatting rules using the mvn formatter:format target. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.

… required on CLIENT and READONLY command

Using custom credentials provider can delay providing of credentials. In this case applyPostHandshake and applyConnectionMetadata got executed before handshake and lead to NOAUTH error in the log for CLIENT command.
@ggivo ggivo marked this pull request as draft October 30, 2024 17:03
@ggivo ggivo self-assigned this Oct 30, 2024
@ggivo ggivo marked this pull request as ready for review October 31, 2024 05:19
Copy link
Collaborator

@tishun tishun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks for fixing this!

@tishun tishun merged commit 7f455ec into redis:main Oct 31, 2024
5 checks passed
@ggivo ggivo deleted the 2996-noauth-on-delayed-credentials branch November 4, 2024 14:06
@tishun tishun added this to the 6.5.0.RELEASE milestone Dec 30, 2024
tishun pushed a commit that referenced this pull request Dec 30, 2024
… required on CLIENT and READONLY command (#3035)

Using custom credentials provider can delay providing of credentials. In this case applyPostHandshake and applyConnectionMetadata got executed before handshake and lead to NOAUTH error in the log for CLIENT command.
thachlp pushed a commit to thachlp/lettuce that referenced this pull request Dec 31, 2024
… required on CLIENT and READONLY command (redis#3035)

Using custom credentials provider can delay providing of credentials. In this case applyPostHandshake and applyConnectionMetadata got executed before handshake and lead to NOAUTH error in the log for CLIENT command.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

io.lettuce.core.RedisCommandExecutionException: NOAUTH Authentication required on CLIENT and READONLY command

2 participants