Refactor JsonValue to Object mapping #3412 #3413
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey, thanks for the contribution! Seems there are still issues with the change, can you address them? |
|
You're welcome. This must have happened because I used GitHub's 'resolve conflict' feature in the browser. I'm going to rebase my branch on the current main. |
We now pass the ObjectMapper defined on the DefaultJsonParser to JsonValue and its subclasses. This ObjectMapper is used to map raw JSON nodes to specialized object instances. Benefits: 1. We avoid creating new ObjectMapper instances over and over again. 2. We are able to configure the ObjectMapper. Closes redis#3412.
brushmate
force-pushed
the
reuse-objectmapper-delegate-json-value
branch
from
9054e1b to
311179f
Compare
a-TODO-rov
approved these changes
Sep 2, 2025
There was a problem hiding this comment.
LGTM
Thank you @brushmate !
I will merge it and will backport it to 6.8
tishun
pushed a commit
to tishun/lettuce-core
that referenced
this pull request
Sep 2, 2025
We now pass the ObjectMapper defined on the DefaultJsonParser to JsonValue and its subclasses. This ObjectMapper is used to map raw JSON nodes to specialized object instances. Benefits: 1. We avoid creating new ObjectMapper instances over and over again. 2. We are able to configure the ObjectMapper. Closes redis#3412.
tishun
pushed a commit
that referenced
this pull request
Sep 2, 2025
We now pass the ObjectMapper defined on the DefaultJsonParser to JsonValue and its subclasses. This ObjectMapper is used to map raw JSON nodes to specialized object instances. Benefits: 1. We avoid creating new ObjectMapper instances over and over again. 2. We are able to configure the ObjectMapper. Closes #3412.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now pass the ObjectMapper defined on the DefaultJsonParser to JsonValue and its subclasses. This ObjectMapper is used to map raw JSON nodes to specialized object instances.
Benefits:
Closes #3412.
Make sure that:
mvn formatter:formattarget. Don’t submit any formatting related changes.