Skip to content

Conversation

collinfunk
Copy link
Contributor

The '-r' option to 'ln' is a GNU extension that is not supported by 'ln' on MacOS. Therefore, we can limit PREFIX to canonical paths to avoid its use.

The '-r' option to 'ln' is a GNU extension that is not supported by 'ln'
on MacOS. Therefore, we can limit PREFIX to canonical paths to avoid its
use.
@collinfunk
Copy link
Contributor Author

I think that this limitation should be quickly understood since Autoconf places similar restrictions on --prefix:

$ ./configure --prefix=./test
configure: error: expected an absolute directory name for --prefix: ./test

Copy link
Collaborator

@moticless moticless left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@moticless moticless merged commit 347e9e1 into redis:main May 15, 2025
8 checks passed
@collinfunk collinfunk deleted the avoid-ln-r branch May 15, 2025 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants