perf(ts)!: move multi() away from RedisClient #3081
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RedisClientMultiCommandType is slow to typecheck because of its recursive nature and the fact that it has many ( around 700 ) methods. Most of the users dont use multi(), so there is no point to incur the ts costs to them. One possible solution is to move the multi() method away from the main RedisClient, thus typechecking will not apply to RedisClientMultiCommandType.
This is a breaking change.
Usage before:
Usage after:
Description
Checklist
npm test
pass with this change (including linting)?