Fix: RedisVL breaks existing logging configurations #301
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: Prevent RedisVL from overriding existing logging configurations
Issue
When importing any RedisVL component, the library currently overrides existing user-defined logging configurations silently. This happens because
coloredlogs.install()is called during module import inredisvl/utils/log.py, which affects the root logger without the user's knowledge or consent.Changes
get_loggerfunction inlog.pyto respect existing logging configurationsreconfigure=Falseto prevent modifying existing loggersisatty=Trueto only use colors in supported terminalsTesting
Replicates the before RedisVL is loaded scenario by using an external (to the test) py file that's run on it's own process
Fixes #293