-
Notifications
You must be signed in to change notification settings - Fork 2
Add Schema Registry import mode #28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
📝 WalkthroughWalkthrough
Sequence Diagram(s)sequenceDiagram
autonumber
actor Client
participant API as Schema Registry API
rect rgba(200,230,255,0.3)
note over Client,API: PUT /mode (global) — NEW: optional force, NEW enum value IMPORT
Client->>API: PUT /mode?mode=IMPORT&force=true?
alt force=true (optional)
API->>API: Apply mode with force override
else force not provided/false
API->>API: Apply mode with standard checks
end
API-->>Client: 200 OK / error
end
sequenceDiagram
autonumber
actor Client
participant API as Schema Registry API
rect rgba(200,255,200,0.3)
note over Client,API: PUT /mode/{subject} — NEW: optional force, NEW enum value IMPORT
Client->>API: PUT /mode/{subject}?mode=IMPORT&force=true?
alt force=true (optional)
API->>API: Apply subject mode with force override
else force not provided/false
API->>API: Apply subject mode with standard checks
end
API-->>Client: 200 OK / error
end
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Pre-merge checks and finishing touches✅ Passed checks (5 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Comment |
🤖 API structural change detected: Modified (2)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
schema-registry/schema-registry.json (2)
229-242
: Document defaultfalse
forforce
.Swagger/OpenAPI consumers will benefit from the explicit default. Adding
"default": false
makes it clear that omitting the flag preserves the existing emptiness check."required": false, - "type": "boolean" + "type": "boolean", + "default": false
333-346
: Mirror theforce
default on subject-level mode updates.Same reasoning as the global mode endpoint—stating
"default": false
keeps the documentation unambiguous for generated clients and readers."required": false, - "type": "boolean" + "type": "boolean", + "default": false
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
- Jira integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
schema-registry/schema-registry.json
(4 hunks)
This pull request updates the Schema Registry API specification to support a new mode and adds an option to override checks when setting modes. The changes primarily affect the
schema-registry/schema-registry.json
file and introduce a newIMPORT
mode, as well as aforce
query parameter for relevant endpoints.API feature additions:
Added support for a new
IMPORT
mode to themode
definition, expanding the possible values for schema registry operation modes.Introduced a new optional
force
query parameter to the global mode-setting endpoint, allowing clients to override the emptiness check when setting the global mode toIMPORT
.Added the same optional
force
query parameter to the subject mode-setting endpoint, enabling override of the emptiness check for individual subjects when switching toIMPORT
mode.Version update:
1.1.0
to1.1.1
to reflect these changes.