-
Notifications
You must be signed in to change notification settings - Fork 2
Add Admin v2 spec file #29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the 📝 WalkthroughWalkthroughThis pull request introduces a new comprehensive OpenAPI v3.1 specification for the Redpanda Admin API v2.0.0, including definitions for three services (BrokerService, ShadowLinkService) and an extensive set of public schemas covering brokers, shadow links, shadow topics, TLS configuration, authentication, and supporting types. A documentation link is added to the existing admin.yaml file. A new overlay file is introduced to augment the Admin API v2 specification with descriptive text and external documentation references. Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes The primary file (admin-v2.yaml) is substantial and contains many interconnected schema definitions for the new Admin API v2 service. While the changes follow repetitive OpenAPI specification patterns—making portions homogeneous—the breadth of schemas, endpoint definitions, and nested structures requires careful validation for correctness, consistency, and completeness. The secondary changes to admin.yaml and the new overlay file are straightforward. Reviewers should verify schema coherence, endpoint accuracy, type definitions, and alignment with the stated Shadow Link API objectives. Suggested reviewers
Pre-merge checks and finishing touches❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
Comment |
|
ℹ️ API content change detected: No structural change, nothing to display.
|
Uh oh!
There was an error while loading. Please reload this page.