Skip to content

Small fixes #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Small fixes #36

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
867985c
fix: add ssm role to agent instance profile
ligfx Oct 15, 2024
38f6a53
fix: don't jsonencode output.private_subnet_ids
ligfx Oct 15, 2024
65a0288
fix: add public subnets by default
ligfx Oct 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion customer-managed/aws/terraform/iam_redpanda_agent.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -901,7 +901,8 @@ resource "aws_iam_role_policy_attachment" "redpanda_agent" {
for_each = {
"1" = aws_iam_policy.redpanda_agent["1"].arn,
"2" = aws_iam_policy.redpanda_agent["2"].arn,
"3" = aws_iam_policy.redpanda_agent["3"].arn
"3" = aws_iam_policy.redpanda_agent["3"].arn,
"ssm" = "arn:aws:iam::aws:policy/AmazonSSMManagedInstanceCore"
}
role = aws_iam_role.redpanda_agent.name
policy_arn = each.value
Expand Down
2 changes: 1 addition & 1 deletion customer-managed/aws/terraform/outputs.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ output "vpc_arn" {
}

output "private_subnet_ids" {
value = jsonencode([for o in data.aws_subnet.private : o["arn"]])
value = [for o in data.aws_subnet.private : o["arn"]]
description = "Private subnet IDs created"
precondition {
condition = length(data.aws_subnet.private) > 0
Expand Down
11 changes: 6 additions & 5 deletions customer-managed/aws/terraform/variables.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,11 @@ variable "aws_account_id" {

variable "public_subnet_cidrs" {
type = list(string)
default = []
default = [
"10.0.1.0/24",
"10.0.3.0/24",
"10.0.5.0/24"
]
description = <<-HELP
One public subnet will be created per cidr in this list.
HELP
Expand All @@ -27,10 +31,7 @@ variable "private_subnet_cidrs" {
default = [
"10.0.0.0/24",
"10.0.2.0/24",
"10.0.4.0/24",
"10.0.6.0/24",
"10.0.8.0/24",
"10.0.10.0/24"
"10.0.4.0/24"
]
description = <<-HELP
One private subnet will be created per cidr in this list.
Expand Down