Skip to content

Use absolute tools dir #3566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Use absolute tools dir #3566

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Taskfile.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ dotenv:

vars:
TARGET_DIR: target
TOOLS_BIN_DIR: bin
TOOLS_BIN_DIR: '{{.USER_WORKING_DIR}}/bin'
VERSION:
sh: git describe --tags 2>/dev/null | sed 's/^v//' || echo "0.0.0"

Expand Down
9 changes: 6 additions & 3 deletions taskfiles/tools.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,17 +10,20 @@ tasks:
desc: Install golangci-lint
required:
vars:
- TOOLS_BIN_DIR
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we could use env in this file to avoid both GOBIN and ad-hoc TOOLS_BIN_DIR var requirements

- GOLANGCI_LINT_VERSION
run: once
silent: true
sources:
- .versions
cmds:
- GOBIN={{.GOBIN}} go install github.com/golangci/golangci-lint/v2/cmd/golangci-lint@v{{.GOLANGCI_LINT_VERSION}}
- GOBIN={{.TOOLS_BIN_DIR}} go install github.com/golangci/golangci-lint/v2/cmd/golangci-lint@v{{.GOLANGCI_LINT_VERSION}}

install-govulncheck:
desc: Install govulncheck
required:
vars:
- TOOLS_BIN_DIR
run: always
silent: true
cmds:
- GOBIN={{.GOBIN}} go install golang.org/x/vuln/cmd/govulncheck@latest
- GOBIN={{.TOOLS_BIN_DIR}} go install golang.org/x/vuln/cmd/govulncheck@latest