Move AI agent model into provider, add base_url #2012
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest Buf updates on your PR. Results from workflow Buf CI / validate (pull_request).
|
… model Add model and base_url fields to the OpenAI provider configuration. Keep the existing top-level model field but mark it as deprecated for backward compatibility. The new provider.openai.model field takes precedence when both are set. This allows for a gradual migration path while making the schema cleaner and more extensible for future providers with different model requirements. Changes: - Added optional model field to Provider.OpenAI message - Added optional base_url field to Provider.OpenAI message - Marked top-level model field as deprecated in AIAgent, AIAgentCreate, and AIAgentUpdate - Updated comments to indicate migration path - Regenerated all protobuf code and OpenAPI specs Co-Authored-By: Claude <[email protected]>
birdayz
force-pushed
the
jb/ai-agent-model-in-provider
branch
from
f93f2b5 to
2648f5c
Compare
birdayz
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Motivation
Different LLM providers have different model naming schemes. Keeping model at the provider level makes the schema cleaner and more extensible for future providers.
The base_url field allows using OpenAI-compatible APIs (like Azure OpenAI, local models, etc.) beyond the default OpenAI endpoint.
Backward Compatibility
The existing top-level
modelfield is kept but marked as deprecated to maintain backward compatibility during the transition period. When both fields are set,provider.openai.modeltakes precedence.Note: The deprecated top-level
modelfield will be removed in a future release once all clients have migrated to the new provider-specific field.Changes
modelfield toProvider.OpenAImessagebase_urlfield toProvider.OpenAImessagemodelfield as deprecated inAIAgent,AIAgentCreate, andAIAgentUpdate