[CORE-8556] rptest: ignore sync errors when resetting manifest #28381
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sync errors may happen for a variety of reasons, but generally they are
transient. This was causing the test to fail:
```
[WARNING - 2025-10-08 10:01:40,588 - admin - _request - lineno:805]: Response 500: {"message": "Could not sync with log", "code": 500}
[INFO - 2025-10-08 10:01:40,588 - e2e_shadow_indexing_test - test_reset_from_cloud - lineno:524]: Reset from cloud failed: 500 Server Error: Internal Server Error for url: http://docker-rp-6:9644/v1/cloud_storage/unsafe_reset_metadata_from_cloud/kafka/panda-topic/0
[DEBUG - 2025-10-08 10:01:43,407 - kgo_verifier_services - _ingest_status - lineno:433]: KgoVerifierProducer-0-139894623949760 status: [{'topic': 'panda-topic', 'sent': 89864, 'acked': 88839, 'bad_offsets': 0, 'max_offsets_produced': {'0': 88838}, 'restarts': 0, 'fails': 0, 'tombstones_produced': 0, 'failed_transactions': 0, 'aborted_transaction_msgs': 0, 'latency': {'p50': 13798.5, 'p90': 21826, 'p99': 370127}, 'active': True}]
...
[ERROR - 2025-10-08 10:02:05,643 - cluster - _do_post_test_checks - lineno:136]: Test failed, doing failure checks on RedpandaService-0-139894623572640...
Traceback (most recent call last):
File "/root/tests/rptest/services/cluster.py", line 246, in wrapped
r = f(self, *args, **kwargs)
File "/root/tests/rptest/tests/e2e_shadow_indexing_test.py", line 537, in test_reset_from_cloud
assert resets_failed == 0, f"{resets_failed} resets failed during the test"
AssertionError: 1 resets failed during the test
```
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR addresses test failures caused by transient "Could not sync with log" errors during cloud metadata reset operations in the e2e_shadow_indexing_test. The fix adds logic to ignore these benign sync errors, preventing them from being counted as unexpected failures.
Key changes:
- Added specific handling for "Could not sync with log" errors in the reset operation
- Distinguished transient sync errors from actual failures to improve test stability
andrwng
changed the title
Collaborator
CI test resultstest results on build#75690
|
Contributor
Author
|
/ci-repeat 4 |
WillemKauf
approved these changes
Nov 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sync errors may happen for a variety of reasons, but generally they are transient. This was causing the test to fail:
Backports Required
Release Notes