Skip to content

application: stop schema_registry clients before datalake subsystems #28391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

application: stop schema_registry clients before datalake subsystems #28391

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/v/pandaproxy/schema_registry/api.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,6 +112,10 @@ ss::future<> api::start() {
co_await _service.invoke_on_all(&service::start);
}

ss::future<> api::stop_clients() {
co_await _client.invoke_on_all(&kafka::client::client::stop);
}

ss::future<> api::stop() {
vlog(srlog.debug, "Stopping schema registry API...");
co_await _client.invoke_on_all(&kafka::client::client::stop);
Expand Down
1 change: 1 addition & 0 deletions src/v/pandaproxy/schema_registry/api.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@ class api {

ss::future<> start();
ss::future<> stop();
ss::future<> stop_clients();
ss::future<> restart();

const configuration& get_config() const;
Expand Down
5 changes: 5 additions & 0 deletions src/v/redpanda/application.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -374,6 +374,11 @@ void application::shutdown() {
return cloud_io.invoke_on_all(&cloud_io::remote::request_stop);
});
}
// Shutdown schema registry clients before the datalake subsystems to
// ensure the datalake subsystems can shutdown quickly.
if (_schema_registry) {
_schema_registry->stop_clients().get();
}
/**
* Shutdown the datalake services before stopping all the partitions.
* NOTE: translators may call into the coordinator via the coordinator
Expand Down