partition_balancer: report quorum loss moves as... #28393
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
immutable nodes_decommissioning_test.py ::NodesDecommissioningTest .test_decommissioning_node_rf_1_replica would periodically fail on partitions not being reported as allocation failures. This happened because there was a race. A partition would NOT be reported as an allocation failure if there was a move in progress. In this test, the node is stopped and then the decommed. As a result, the broker could be picked up as unresponsive, which would init a move before the decomission is made visible to the planner. This commit changes pbp to report in-progress moves with quorum loss on the original replica set as immutable.
Contributor
Author
|
/ci-repeat 1 |
Collaborator
CI test resultstest results on build#75724
test results on build#75764
|
joe-redpanda
requested review from
bashtanov,
bharathv,
Copilot and
mmaslankaprv
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a race condition in the partition balancer planner where partitions that have lost quorum during an in-progress move were not being reported as allocation failures. The fix ensures that partitions with an in-flight move and quorum loss on the original replica set are now correctly reported as immutable.
Key Changes:
- Added quorum loss detection for partitions during in-progress moves
- Partitions that lost quorum during moves are now reported as immutable with
no_quorumreason - Restructured control flow to handle the new quorum loss case before attempting cancellations
mmaslankaprv
approved these changes
Nov 21, 2025
Contributor
Author
|
Collaborator
|
/backport v25.3.x |
Collaborator
|
/backport v25.2.x |
Collaborator
|
/backport v25.1.x |
Collaborator
|
/backport v24.3.x |
This was referenced Nov 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...immutable
nodes_decommissioning_test.py
::NodesDecommissioningTest
.test_decommissioning_node_rf_1_replica
would periodically fail on partitions not being reported as allocation failures. This happened because there was a race. A partition would NOT be reported as an allocation failure if there was a move in progress.
In this test, the node is stopped and then the decommed. As a result, the broker could be picked up as unresponsive, which would init a move before the decomission is made visible to the planner.
This commit changes pbp to report in-progress moves with quorum loss on the original replica set as immutable.
Backports Required
Release Notes
Improvements