[CORE-14434] rptest: Fix timequery test #28428
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a failing timequery test by updating the base timestamp used for generating test records. The test was using a hardcoded timestamp from 2022 (1664453149000), which is now old enough that Redpanda's retention policy would delete the data while the test is running, causing test failures. The fix changes to using the current system time as the base timestamp.
- Changed hardcoded old timestamp to dynamically generated current timestamp using
int(time.time()) * 1000
Lazin
changed the title
WillemKauf
reviewed
Nov 7, 2025
tests/rptest/tests/timequery_test.py
Outdated
| @ducktape_cluster(num_nodes=7) | ||
| def test_timequery(self): | ||
| base_ts = 1664453149000 | ||
| base_ts = int(time.time()) * 1000 |
Contributor
There was a problem hiding this comment.
There are a lot more base_ts = 1664453149000 in this file, do more sites need to be amended?
Contributor
There was a problem hiding this comment.
at this point I think a base class with one accessible self.base_ts definition might be more ideal but I don't feel strongly about you changing it for this PR.
Lazin
force-pushed
the
fix/timequery-test
branch
from
243c952 to
2bed837
Compare
Collaborator
CI test resultstest results on build#75855
test results on build#76111
test results on build#76127
|
WillemKauf
approved these changes
Nov 7, 2025
tests/rptest/tests/timequery_test.py
Outdated
| @ducktape_cluster(num_nodes=7) | ||
| def test_timequery(self): | ||
| base_ts = 1664453149000 | ||
| base_ts = int(time.time()) * 1000 |
Contributor
There was a problem hiding this comment.
at this point I think a base class with one accessible self.base_ts definition might be more ideal but I don't feel strongly about you changing it for this PR.
WillemKauf
requested changes
Nov 7, 2025
Lazin
force-pushed
the
fix/timequery-test
branch
from
2bed837 to
c9e415a
Compare
Lazin
requested review from
a team,
kbatuigas,
michael-redpanda,
r-vasquez and
rockwotj
as code owners
The test uses constant timestamp to generate records and query them. But the timestamp is too old so retention policy starts to remove data while the test is running. This commit makes the test use proper base timestamp. Signed-off-by: Evgeny Lazin <[email protected]>
Lazin
force-pushed
the
fix/timequery-test
branch
from
c9e415a to
033ca19
Compare
Lazin
requested review from
WillemKauf
and removed request for
a team,
dotnwat,
kbatuigas,
michael-redpanda,
r-vasquez and
rockwotj
Contributor
|
/ci-repeat 5 |
Collaborator
|
/backport v25.3.x |
Collaborator
|
/backport v25.2.x |
Collaborator
|
/backport v25.1.x |
Collaborator
|
/backport v24.3.x |
Collaborator
|
Branch name "v25.3.x" not found. |
This was referenced Nov 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test uses constant timestamp to generate records and query them. But the timestamp is too old so retention policy starts to remove data while the test is running. This commit makes the test use proper base timestamp.
Backports Required
Release Notes