Support new PR view in isClosedIssue; tighten related checks
#201
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kovsu
changed the title
isClosedIssue
fregante
reviewed
Nov 6, 2024
fregante
reviewed
Nov 6, 2024
fregante
reviewed
Nov 6, 2024
kovsu
commented
Nov 6, 2024
fregante
changed the title
isClosedIssueisClosedIssue; tighten related checks
fregante
approved these changes
Nov 6, 2024
Member
fregante
left a comment
fregante
left a comment
There was a problem hiding this comment.
I'll let you merge this PR and release a new version. You can do so from the Actions tab, Releases, then type patch in the version field and wait for the release to appear
Member
Author
|
Oh, I should clean the description input when merging. |
Member
|
|
Member
Author
|
It seems doesn't work. Let me check it. 
|
Member
|
It works but it's limited: refined-github/refined-github#6611 (comment) Ignore for now |
fregante
reviewed
Nov 10, 2024
| const stateSelector = [ | ||
| '.State', | ||
| '[class^="StateLabel"]', | ||
| '[data-testid="header-state"]', |
Member
There was a problem hiding this comment.
data-testid is already gone :(
Test URL: https://github.com/refined-github/refined-github/pull/7987/commits
Member
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.