fix: use only in directory routes on +routes RouteModules #14439
Conversation
🦋 Changeset detectedLatest commit: 58f0964 The changes in this PR will be included in the next version bump. This PR includes changesets to release 11 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
fernandojbf
force-pushed
the
typegen-in-directory-filter
branch
from
711bff3 to
4784e7a
Compare
|
Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳 |
|
This is especially important for routes that are shared through node_modules. I know that, for now, the framework does not officially support this use case, but it’s still possible to reference them using file system paths. I believe the RouteModule type should remain valid even when the route type file is not generated. In my opinion, adding unknown is the recommended approach — it allows us to later decide whether we want to support type definitions for routes outside the project. |
fernandojbf
force-pushed
the
typegen-in-directory-filter
branch
from
4784e7a to
7370b3d
Compare
| isInAppDirectory(ctx, route.file) | ||
| ? t.tsTypeQuery( | ||
| t.tsImportType( | ||
| t.stringLiteral( | ||
| `./${Path.relative(ctx.rootDirectory, ctx.config.appDirectory)}/${route.file}`, | ||
| ), | ||
| ), | ||
| ) | ||
| : t.tsUnknownKeyword(), |
There was a problem hiding this comment.
You might need to add a test to ensure this works properly, don't conflict with anything else and is not removed in the future
There was a problem hiding this comment.
Yes, i did not had time to add it, but i will add it now :)
Thanks
fernandojbf
force-pushed
the
typegen-in-directory-filter
branch
from
7370b3d to
838343f
Compare
fernandojbf
force-pushed
the
typegen-in-directory-filter
branch
from
838343f to
58f0964
Compare
|
I believe PR (Full) / 👀 Integration Test / macos-latest / node@22 / webkit (pull_request) timeout. Can anyone retry this job? |
3 participants
Description
Since React Router’s type generator skips any route located outside the
appdirectory, adding such a route to the+routes.tsRouteModuletype will cause a type error.Because it’s possible to include files from outside the
appfolder using file paths, I believe the type generator should at least fall back tounknownfor those routes.