-
Notifications
You must be signed in to change notification settings - Fork 2.7k
feat(fetch-router): add alias functions for standard HTTP verb paths #10768
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
aaronjordan
wants to merge
7
commits into
remix-run:main
Choose a base branch
from
aaronjordan:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+207
−0
Open
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
669ef25
Add consistent alias functions for standard HTTP verb paths
aaronjordan 439e925
Remove misplaced changelog entry
aaronjordan 95306d4
Merge branch 'remix-run:main' into main
aaronjordan 2309d83
add narrowing type helper for RouteDef and tests for route-helpers
aaronjordan cc3c145
rename createDelete for consistency with shorthand
aaronjordan 05c7650
correct index export
aaronjordan de7ebf1
rename route def object type
aaronjordan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| import type { RoutePattern } from '@remix-run/route-pattern' | ||
|
|
||
| /** | ||
| * Shorthand for a DELETE route. | ||
| */ | ||
| export function createDelete<P extends string>(pattern: P | RoutePattern<P>) { | ||
| return { method: 'DELETE', pattern }; | ||
| } | ||
|
|
||
| /** | ||
| * Shorthand for a GET route. | ||
| */ | ||
| export function createGet<P extends string>(pattern: P | RoutePattern<P>) { | ||
| return { method: 'GET', pattern }; | ||
| } | ||
|
|
||
| /** | ||
| * Shorthand for a POST route. | ||
| */ | ||
| export function createPost<P extends string>(pattern: P | RoutePattern<P>) { | ||
| return { method: 'POST', pattern }; | ||
| } | ||
|
|
||
| /** | ||
| * Shorthand for a PUT route. | ||
| */ | ||
| export function createPut<P extends string>(pattern: P | RoutePattern<P>) { | ||
| return { method: 'PUT', pattern }; | ||
| } |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would this actually go under a new 0.7.0 heading?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The CHANGELOG is updated when a release is created, this if merged would not be part of an already released version