Skip to content

Conversation

rtomas
Copy link
Contributor

@rtomas rtomas commented Sep 12, 2025

Description

delete appkit Core option from cli

Type of change

  • Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Associated Issues

For Linear issues: Closes APKT-xxx
For GH issues: closes #...

Showcase (Optional)

If there is a UI change include the screenshots with before and after state.
If new feature is being introduced, include the link to demo recording.

Checklist

  • Code in this PR is covered by automated tests (Unit tests, E2E tests)
  • My changes generate no new warnings
  • I have reviewed my own code
  • I have filled out all required sections
  • [] I have tested my changes on the preview link
  • Approver of this PR confirms that the changes are tested on the preview link

@Copilot Copilot AI review requested due to automatic review settings September 12, 2025 15:21
Copy link

changeset-bot bot commented Sep 12, 2025

⚠️ No Changeset found

Latest commit: 25d4e04

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Sep 12, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
appkit-basic-html Error Error Sep 17, 2025 8:47am
appkit-demo Error Error Sep 17, 2025 8:47am
appkit-gallery Error Error Sep 17, 2025 8:47am
appkit-laboratory Error Error Sep 17, 2025 8:47am
10 Skipped Deployments
Project Deployment Preview Comments Updated (UTC)
appkit-basic-example Ignored Ignored Sep 17, 2025 8:47am
appkit-basic-sign-client-example Ignored Ignored Sep 17, 2025 8:47am
appkit-basic-up-example Ignored Ignored Sep 17, 2025 8:47am
appkit-ethers5-bera Ignored Ignored Sep 17, 2025 8:47am
appkit-nansen-demo Ignored Ignored Sep 17, 2025 8:47am
appkit-vue-solana Ignored Ignored Sep 17, 2025 8:47am
appkit-wagmi-cdn-example Ignored Ignored Sep 17, 2025 8:47am
ethereum-provider-wagmi-example Ignored Ignored Sep 17, 2025 8:47am
next-wagmi-solana-bitcoin-example Ignored Ignored Sep 17, 2025 8:47am
vue-wagmi-example Ignored Ignored Sep 17, 2025 8:47am

@rtomas rtomas requested review from arein, tomiir and magiziz September 12, 2025 15:21
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the AppKit Core option from the CLI tool while updating several dependencies to newer versions.

  • Removes "AppKit Core" as a selectable library option from the CLI interface
  • Updates multiple dependencies including figlet, inquirer, babel plugins, and cross-env
  • Adds various package manager lock files to .gitignore

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
packages/cli/package.json Updates dependency versions for figlet, inquirer, babel, cross-env, and ts-node
packages/cli/index.js Removes AppKit Core option from library selection prompt
packages/cli/.gitignore Adds lock files for different package managers to ignore list

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

"cross-env": "10.0.0",
"esm": "3.2.25",
"ts-node": "10.9.2"
"ts-node": "10.9.1"
Copy link
Preview

Copilot AI Sep 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This appears to be a downgrade from ts-node 10.9.2 to 10.9.1, which could introduce bugs that were fixed in the newer version. Consider keeping the current version or upgrading to the latest stable release.

Suggested change
"ts-node": "10.9.1"
"ts-node": "10.9.2"

Copilot uses AI. Check for mistakes.

Copy link

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Added@​wagmi/​vue@​0.2.5851007597100
Addedvite@​6.3.595928199100
Addedvite@​5.4.1996938399100
Addedvaltio@​2.1.710010010090100

View full report

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants