Skip to content

chore: use caret version for the viem dependencies #5038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

chore: use caret version for the viem dependencies #5038

Show file tree
Hide file tree
Changes from 8 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
7d309b9
chore: move viem to `optionalDependencies`
enesozturk Sep 16, 2025
c670e07
chore: lock file
enesozturk Sep 16, 2025
12042ec
chore: fix package name
enesozturk Sep 16, 2025
29ff523
chore: use peerDependencies
enesozturk Sep 17, 2025
7937bff
chore: move lit/react back to optional
enesozturk Sep 17, 2025
35ad545
chore: lock file
enesozturk Sep 17, 2025
fca0f9f
Merge branch 'main' into chore/viem-optional-deps
enesozturk Sep 17, 2025
f0cf221
chore: move sdk packages to peerDependencies
enesozturk Sep 17, 2025
007e19e
choer: use wc canary for caret viem version
enesozturk Sep 17, 2025
82cccd5
Merge branch 'main' into chore/viem-optional-deps
enesozturk Sep 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions packages/adapters/ethers/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,15 +29,13 @@
"@walletconnect/universal-provider": "2.21.7",
"valtio": "2.1.7"
},
"optionalDependencies": {
"peerDependencies": {
"@ethersproject/sha2": "5.8.0",
"ethers": ">=6",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Unintended Dependency Changes Cause Installation Issues

Moving @coinbase/wallet-sdk, @safe-global/safe-apps-provider, @safe-global/safe-apps-sdk (in ethers adapters) and @lit/react (in wallet-button) from optionalDependencies to peerDependencies makes these previously optional packages now required. This is a breaking change for consumers, forcing them to install dependencies they might not need and potentially causing installation failures, which also goes beyond the PR's stated scope.

Additional Locations (2)

Fix in Cursor Fix in Web

"@coinbase/wallet-sdk": "4.3.7",
"@safe-global/safe-apps-provider": "0.18.6",
"@safe-global/safe-apps-sdk": "9.1.0"
},
"peerDependencies": {
"@ethersproject/sha2": "5.8.0",
"ethers": ">=6"
},
"devDependencies": {
"@vitest/coverage-v8": "2.1.9",
"@walletconnect/types": "2.21.3",
Expand Down
8 changes: 3 additions & 5 deletions packages/adapters/ethers5/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,15 +29,13 @@
"@walletconnect/universal-provider": "2.21.7",
"valtio": "2.1.7"
},
"optionalDependencies": {
"peerDependencies": {
"@ethersproject/sha2": "5.8.0",
"ethers": ">=4.1 <6.0.0",
"@coinbase/wallet-sdk": "4.3.7",
"@safe-global/safe-apps-provider": "0.18.6",
"@safe-global/safe-apps-sdk": "9.1.0"
},
"peerDependencies": {
"@ethersproject/sha2": "5.8.0",
"ethers": ">=4.1 <6.0.0"
},
"devDependencies": {
"@vitest/coverage-v8": "2.1.9",
"@walletconnect/types": "2.21.3",
Expand Down
4 changes: 2 additions & 2 deletions packages/adapters/wagmi/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,8 @@
},
"peerDependencies": {
"@wagmi/core": ">=2.20.3",
"viem": ">=2.37.1",
"wagmi": ">=2.16.9"
"wagmi": ">=2.16.9",
"viem": ">=2.37.2"
},
"devDependencies": {
"@types/react": "19.1.3",
Expand Down
6 changes: 3 additions & 3 deletions packages/appkit-utils/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,8 +63,7 @@
"@wallet-standard/wallet": "1.1.0",
"@walletconnect/logger": "2.1.2",
"@walletconnect/universal-provider": "2.21.7",
"valtio": "2.1.7",
"viem": ">=2.37.2"
"valtio": "2.1.7"
},
"devDependencies": {
"@walletconnect/types": "2.21.7",
Expand All @@ -80,7 +79,8 @@
"vitest": "3.1.3"
},
"peerDependencies": {
"valtio": "2.1.7"
"valtio": "2.1.7",
"viem": ">=2.37.2"
},
"author": "Reown (https://discord.gg/reown)",
"license": "SEE LICENSE IN LICENSE.md",
Expand Down
6 changes: 4 additions & 2 deletions packages/appkit/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,8 +138,7 @@
"@walletconnect/universal-provider": "2.21.7",
"bs58": "6.0.0",
"semver": "7.7.2",
"valtio": "2.1.7",
"viem": ">=2.37.2"
"valtio": "2.1.7"
},
"devDependencies": {
"@walletconnect/types": "2.21.7",
Expand All @@ -158,6 +157,9 @@
"optionalDependencies": {
"@lit/react": "1.0.8"
},
"peerDependencies": {
"viem": ">=2.37.2"
},
"author": "Reown (https://discord.gg/reown)",
"license": "SEE LICENSE IN LICENSE.md",
"homepage": "https://github.com/reown-com/appkit",
Expand Down
4 changes: 2 additions & 2 deletions packages/cdn/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,8 @@
"vite-plugin-node-polyfills": "0.23.0"
},
"peerDependencies": {
"typescript": "5.8.3"
"typescript": "5.8.3",
"viem": ">=2.37.2"
},
"peerDependenciesMeta": {
"typescript": {
Expand All @@ -37,7 +38,6 @@
"@reown/appkit-polyfills": "workspace:*",
"@wagmi/connectors": "5.9.9",
"@wagmi/core": "2.20.3",
"viem": "2.37.2",
"vite": "5.4.19",
"wagmi": "2.16.9"
},
Expand Down
4 changes: 3 additions & 1 deletion packages/common/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,9 @@
},
"dependencies": {
"big.js": "6.2.2",
"dayjs": "1.11.13",
"dayjs": "1.11.13"
},
"peerDependencies": {
"viem": ">=2.37.2"
},
"devDependencies": {
Expand Down
4 changes: 3 additions & 1 deletion packages/controllers/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,9 @@
"@reown/appkit-common": "workspace:*",
"@reown/appkit-wallet": "workspace:*",
"@walletconnect/universal-provider": "2.21.7",
"valtio": "2.1.7",
"valtio": "2.1.7"
},
"peerDependencies": {
"viem": ">=2.37.2"
},
"devDependencies": {
Expand Down
4 changes: 3 additions & 1 deletion packages/experimental/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,9 +53,11 @@
"@reown/appkit-utils": "workspace:*",
"lit": "3.3.0",
"valtio": "2.1.7",
"viem": "2.37.2",
"zod": "3.22.4"
},
"peerDependencies": {
"viem": ">=2.37.2"
},
"devDependencies": {
"@vitest/coverage-v8": "2.1.9",
"vitest": "3.1.3"
Expand Down
6 changes: 4 additions & 2 deletions packages/siwe/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,10 @@
"@reown/appkit-wallet": "workspace:*",
"@walletconnect/utils": "2.21.7",
"lit": "3.1.0",
"valtio": "2.1.7",
"viem": "2.37.2"
"valtio": "2.1.7"
},
"peerDependencies": {
"viem": ">=2.37.2"
},
"author": "Reown (https://discord.gg/reown)",
"license": "SEE LICENSE IN LICENSE.md",
Expand Down
6 changes: 3 additions & 3 deletions packages/siwx/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,7 @@
"@reown/appkit-utils": "workspace:*",
"bip322-js": "2.0.0",
"bs58": "6.0.0",
"tweetnacl": "1.0.3",
"viem": "2.37.2"
"tweetnacl": "1.0.3"
},
"devDependencies": {
"@types/react": "19.1.3",
Expand All @@ -53,7 +52,8 @@
"vue": "3.5.13"
},
"peerDependencies": {
"lit": "3.3.0"
"lit": "3.3.0",
"viem": ">=2.37.2"
},
"author": "Reown (https://discord.gg/reown)",
"license": "SEE LICENSE IN LICENSE.md",
Expand Down
2 changes: 1 addition & 1 deletion packages/wallet-button/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@
"lit": "3.3.0",
"valtio": "2.1.7"
},
"optionalDependencies": {
"peerDependencies": {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Unintended Dependency Change Breaks Consumers

Moving @lit/react from optionalDependencies to peerDependencies in packages/wallet-button/package.json makes it a required dependency. This breaking change appears unintentional, as it's unrelated to the PR's stated goal of moving viem dependencies, and could break existing consumers.

Fix in Cursor Fix in Web

"@lit/react": "1.0.8"
},
"author": "Reown (https://discord.gg/reown)",
Expand Down
Loading
Loading