Skip to content

Conversation

NightTTQ
Copy link

@NightTTQ NightTTQ commented Sep 18, 2025

Description

Fixed an issue where subscribing to events using the subscribeAccount, subscribeShouldUpdateToAddress, and subscribeCaipNetworkChange functions did not return the corresponding unsubscribe functions.

Type of change

  • Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Associated Issues

For Linear issues: Closes APKT-xxx
For GH issues: closes #...

Showcase (Optional)

const appKit = createAppKit({
  projectId,
  networks,
});
// before: unsubscribe is void. Cannot unsubscribe.
const unsubscribe = appKit.subscribeAccount(callback, namespace);
// after: unsubscribe is a function. It can be called to unsubscribe.

Checklist

  • Code in this PR is covered by automated tests (Unit tests, E2E tests)
  • My changes generate no new warnings
  • I have reviewed my own code
  • I have filled out all required sections
  • I have tested my changes on the preview link
  • Approver of this PR confirms that the changes are tested on the preview link

Copy link

changeset-bot bot commented Sep 18, 2025

⚠️ No Changeset found

Latest commit: 834c19a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Sep 18, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Updated (UTC)
appkit-gallery Ready Ready Preview Sep 22, 2025 0:34am

Copy link

vercel bot commented Sep 18, 2025

@NightTTQ is attempting to deploy a commit to the Reown Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Contributor

github-actions bot commented Sep 18, 2025

All contributors have signed the CTA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@NightTTQ
Copy link
Author

I have read the CTA Document and I hereby sign the CTA

@NightTTQ
Copy link
Author

Hi @tomiir @enesozturk
I noticed that my pull request is currently awaiting workflow approval. Could you please review and approve the workflow so that the CI checks can run? Thank you for your time and assistance!🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant