Skip to content

DO NOT MERGE: feat/sa version 7 #5310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

DO NOT MERGE: feat/sa version 7 #5310

wants to merge 2 commits into from

Conversation

@tomiir
Copy link
Collaborator

@tomiir tomiir commented Nov 3, 2025 •
edited by cursor bot
Loading

Description

  • set sa version to 7

Type of change

  • Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Associated Issues

For Linear issues: Closes APKT-xxx
For GH issues: closes #...

Showcase (Optional)

If there is a UI change include the screenshots with before and after state.
If new feature is being introduced, include the link to demo recording.

Checklist

  • Code in this PR is covered by automated tests (Unit tests, E2E tests)
  • My changes generate no new warnings
  • I have reviewed my own code
  • I have filled out all required sections
  • I have tested my changes on the preview link
  • Approver of this PR confirms that the changes are tested on the preview link

Note

Pass smartAccountVersion=v7 to the secure site SDK and bump package version to 1.8.12.

  • Wallet:
    • Add smartAccountVersion=v7 to secure site SDK URL in packages/wallet/src/W3mFrame.ts.
  • AppKit:
    • Bump PACKAGE_VERSION to 1.8.12 in packages/appkit/exports/constants.ts.

Written by Cursor Bugbot for commit 0e10921. This will update automatically on new commits. Configure here.

Copilot AI review requested due to automatic review settings November 3, 2025 12:45
@changeset-bot
Copy link

changeset-bot bot commented Nov 3, 2025

⚠️ No Changeset found

Latest commit: 0e10921

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Nov 3, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
appkit-basic-html Ready Ready Preview Comment Nov 3, 2025 0:51am
appkit-demo Ready Ready Preview Comment Nov 3, 2025 0:51am
appkit-gallery Ready Ready Preview Comment Nov 3, 2025 0:51am
appkit-laboratory Ready Ready Preview Comment Nov 3, 2025 0:51am
10 Skipped Deployments
Project Deployment Preview Comments Updated (UTC)
appkit-basic-example Ignored Ignored Nov 3, 2025 0:51am
appkit-basic-sign-client-example Ignored Ignored Nov 3, 2025 0:51am
appkit-basic-up-example Ignored Ignored Nov 3, 2025 0:51am
appkit-ethers5-bera Ignored Ignored Nov 3, 2025 0:51am
appkit-nansen-demo Ignored Ignored Nov 3, 2025 0:51am
appkit-vue-solana Ignored Ignored Nov 3, 2025 0:51am
appkit-wagmi-cdn-example Ignored Ignored Nov 3, 2025 0:51am
ethereum-provider-wagmi-example Ignored Ignored Nov 3, 2025 0:51am
next-wagmi-solana-bitcoin-example Ignored Ignored Nov 3, 2025 0:51am
vue-wagmi-example Ignored Ignored Nov 3, 2025 0:51am

@github-actions
Copy link
Contributor

github-actions bot commented Nov 3, 2025

Visual Regression Test Results ✅ Passed

✨ No visual changes detected

Chromatic Build: https://www.chromatic.com/build?appId=6493191bf4b10fed8ca7353f&number=279
Storybook Preview: https://6493191bf4b10fed8ca7353f-dicrrvtkkc.chromatic.com/

Copilot AI reviewed Nov 3, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the smart account version to v7 in the wallet SDK configuration and bumps the package version to 1.8.12.

Key Changes:

  • Sets smartAccountVersion URL parameter to 'v7' for the secure site SDK
  • Bumps package version from 1.8.11 to 1.8.12

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
packages/wallet/src/W3mFrame.ts Adds hardcoded smartAccountVersion=v7 query parameter to the secure site SDK URL
packages/appkit/exports/constants.ts Updates package version to 1.8.12

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

packages/wallet/src/W3mFrame.ts
url.searchParams.set('version', SECURE_SITE_SDK_VERSION)
url.searchParams.set('enableLogger', String(enableLogger))
url.searchParams.set('rpcUrl', rpcUrl)
url.searchParams.set('smartAccountVersion', 'v7')
Copy link

Copilot AI Nov 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] The smart account version is hardcoded to 'v7'. Consider making this configurable through the W3mFrameConfig interface to allow flexibility for different versions or environments without requiring code changes.

Copilot uses AI. Check for mistakes.
@github-actions
Copy link
Contributor

github-actions bot commented Nov 3, 2025

📦 Bundle Size Check

✅ All bundles are within size limits

📊 View detailed bundle sizes

> @reown/[email protected] size /home/runner/work/appkit/appkit

> size-limit

@reown/appkit - Main Entry
Size limit:   80 kB
Size:         70.62 kB with all dependencies, minified and gzipped
Loading time: 1.4 s    on slow 3G
Running time: 713 ms   on Snapdragon 410
Total time:   2.1 s
@reown/appkit/react
Size limit:   230 kB
Size:         227.29 kB with all dependencies, minified and gzipped
Loading time: 4.5 s     on slow 3G
Running time: 1.1 s     on Snapdragon 410
Total time:   5.5 s
@reown/appkit/vue
Size limit:   80 kB
Size:         70.62 kB with all dependencies, minified and gzipped
Loading time: 1.4 s    on slow 3G
Running time: 428 ms   on Snapdragon 410
Total time:   1.9 s
@reown/appkit-scaffold-ui
Size limit:   220 kB
Size:         207.3 kB with all dependencies, minified and gzipped
Loading time: 4.1 s    on slow 3G
Running time: 1.1 s    on Snapdragon 410
Total time:   5.2 s
@reown/appkit-ui
Size limit:   500 kB
Size:         13.15 kB with all dependencies, minified and gzipped
Loading time: 257 ms   on slow 3G
Running time: 98 ms    on Snapdragon 410
Total time:   355 ms

@github-actions
Copy link
Contributor

github-actions bot commented Nov 3, 2025

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 79.89% 37997 / 47560
🔵 Statements 79.89% 37997 / 47560
🔵 Functions 77.94% 4103 / 5264
🔵 Branches 86.5% 9201 / 10636
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/appkit/exports/constants.ts 100% 100% 100% 100%
packages/wallet/src/W3mFrame.ts 97.91% 82.14% 76.47% 97.91% 41-42, 105-106
Generated in workflow #16155 for commit 0e10921 by the Vitest Coverage Report Action

@tomiir tomiir closed this Nov 6, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Nov 6, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

Copilot code review Copilot Copilot left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tomiir