fix: session methods analytics #92
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xDarksome
approved these changes
Jul 11, 2025
| self.request(rpc::ApproveSession { | ||
| pairing_topic, | ||
| session_topic, | ||
| pairing_response: pairing_response.into(), |
There was a problem hiding this comment.
Not that it was 'wrong', but @llbartekll suggested a better alternative, more consistent with other fields there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds the analytics data to the
wc_proposeSessionandwc_approveSessionmethods.How Has This Been Tested?
Existing tests here and in the relay.
Due Diligence