feat: sign client

[chris13524]

No description provided.

[Copilot]

Pull Request Overview

This pull request adds session persistence functionality to the Yttrium Sign client, allowing sessions to be maintained across application restarts. The implementation includes client state management, cryptographic key persistence, and enhanced session handling capabilities.

Key changes:

• Session storage and retrieval with encrypted state persistence
• Cryptographic utilities for topic generation and Diffie-Hellman key exchange
• Comprehensive session request handling and WebSocket message processing
• End-to-end testing infrastructure with Playwright

Reviewed Changes

Copilot reviewed 14 out of 16 changed files in this pull request and generated 6 comments.

Show a summary per file

File	Description
crates/yttrium/src/sign/utils.rs	Adds cryptographic utilities for topic generation and key exchange
crates/yttrium/src/sign/protocol_types.rs	Defines JSON-RPC message structures for session management
crates/yttrium/src/sign/mod.rs	Major refactor to support session persistence and improved WebSocket handling
crates/rust-sample-wallet/src/app.rs	New UI component for session management with local storage integration
crates/rust-sample-wallet/src/main.rs	Simplified main entry point with logging configuration
Other files	Supporting files for testing infrastructure and UI components

Files not reviewed (1)

• crates/rust-sample-wallet/package-lock.json: Language not supported

[Copilot]

The unwrap() call should be replaced with proper error handling. HKDF expand operations can fail and should return a proper error type instead of panicking.

Suggested change

	) -> [u8; 32] {
	let shared_key = private_key.diffie_hellman(public_key);
	let derived_key = hkdf::Hkdf::<Sha256>::new(None, shared_key.as_bytes());
	let mut expanded_key = [0u8; 32];
	derived_key.expand(b"", &mut expanded_key).unwrap();
	expanded_key
	) -> Result<[u8; 32], hkdf::InvalidLength> {
	let shared_key = private_key.diffie_hellman(public_key);
	let derived_key = hkdf::Hkdf::<Sha256>::new(None, shared_key.as_bytes());
	let mut expanded_key = [0u8; 32];
	derived_key.expand(b"", &mut expanded_key)?;
	Ok(expanded_key)

[Copilot]

Using web_sys::console::log_1 for error handling in production code is not ideal. Consider using the tracing crate which is already imported for consistent logging.

Suggested change

	web_sys::console::log_1(&format!("Failed to send response: {e:?}").into());
	tracing::error!("Failed to send response: {:?}", e);

[Copilot]

Duplicate error logging pattern using web_sys::console::log_1. This should be consistent with the tracing infrastructure used elsewhere in the codebase.

Suggested change

	web_sys::console::log_1(&format!("Failed to send response: {e:?}").into());
	tracing::error!("Failed to send response: {:?}", e);

[Copilot]

Debug logging using web_sys::console::log_1 should be replaced with tracing::debug! for consistency with the logging infrastructure.

Suggested change

	web_sys::console::log_1(&message.clone().into());
	tracing::debug!("{}", message.clone());

[Copilot]

The expect("TODO") indicates incomplete error handling. This should be replaced with proper error propagation or a more descriptive error message.

Suggested change

	result: serde_json::to_value(true).expect("TODO"),
	jsonrpc: "2.0".to_string().into(),
	}));
	let serialized = serde_json::to_string(&request).map_err(|e| {
	RequestError::ShouldNeverHappen(format!(
	"Failed to serialize request: {e}"
	))
	}).expect("TODO");
	result: serde_json::to_value(true).map_err(|e| {
	RequestError::Internal(format!(
	"Failed to serialize result: {e}"
	))
	})?,
	jsonrpc: "2.0".to_string().into(),
	}));
	let serialized = serde_json::to_string(&request).map_err(|e| {
	RequestError::ShouldNeverHappen(format!(
	"Failed to serialize request: {e}"
	))
	})?;

[Copilot]

Another expect("TODO") that should be replaced with proper error handling to avoid potential panics in production code.