fix: nil pointer evaluating interface {}.databaseURL#7726
Open
ductnn wants to merge 1 commit intorequarks:mainfrom
Open
fix: nil pointer evaluating interface {}.databaseURL#7726ductnn wants to merge 1 commit intorequarks:mainfrom
ductnn wants to merge 1 commit intorequarks:mainfrom
Conversation
Signed-off-by: ductnn <trannhuduc531998@gmail.com>
Member
|
You're introducing a condition where the object might exist but not the databaseURL, in which case nothing will work. It would be better to keep it as a single condition and use something like dig to perform the check. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.