Skip to content

target/riscv: fix potential UB reported by ubsan in ac cache lookup #1297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: riscv
Choose a base branch
from
Open

target/riscv: fix potential UB reported by ubsan in ac cache lookup #1297

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/target/riscv/riscv-013.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,6 +201,8 @@ static void ac_cache_insert(struct ac_cache *cache, uint32_t command)

static bool ac_cache_contains(const struct ac_cache *cache, uint32_t command)
{
if (cache->size == 0)
return false;
return bsearch(&command, cache->commands, cache->size,
sizeof(*cache->commands), ac_cache_elem_comparator);
}
Expand Down