Open
Conversation
Contributor
|
Here are some of my concerns:
Another point is we already have riscv/sail-riscv, and we should add these codes their. However from my point of view, that's only a concrete RISC-V software implementation, doesn't formally define the instruction and the architecture state, we need to have a sound definition of extensions and each instructions. But after all, the repo is riscv-opcodes, which only defines the opcode for RISC-V, I personally like this, but anyway need to ask @aswaterman to decide should we add these sail implementation snippets here:) |
sequencer
reviewed
Mar 13, 2025
Comment on lines
+4
to
+7
| if taken then { | ||
| let t : xlenbits = PC + sign_extend(bimm12 @ 0b0); | ||
| nextPC = t; | ||
| } No newline at end of file |
Contributor
There was a problem hiding this comment.
The branch and jal update the nextPC, why other instructions doesn't?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
relate to #339