Convert LayoutGridField to function components #4807
Draft
+752
−749
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| "homepage": "https://github.com/rjsf-team/react-jsonschema-form", | ||
| "publishConfig": { | ||
| "access": "public" | ||
| }, |
| return null; | ||
| } | ||
|
|
||
| /** Renders a material-ui `GridTemplate` as an item. The `layoutGridSchema` for the `GridType.COLUMN` is separated |
There was a problem hiding this comment.
That material-ui was a left-over from my original implementation. Also consider reformatting the comments to make them flow across lines properly when you remove it
Suggested change
| /** Renders a material-ui `GridTemplate` as an item. The `layoutGridSchema` for the `GridType.COLUMN` is separated | |
| /** Renders a `GridTemplate` as an item. The `layoutGridSchema` for the `GridType.COLUMN` is separated |
| ); | ||
| } | ||
|
|
||
| /** Renders a material-ui `GridTemplate` as an item. The `layoutGridSchema` for the `GridType.COLUMNS` is separated |
There was a problem hiding this comment.
Ditto
Suggested change
| /** Renders a material-ui `GridTemplate` as an item. The `layoutGridSchema` for the `GridType.COLUMNS` is separated | |
| /** Renders a `GridTemplate` as an item. The `layoutGridSchema` for the `GridType.COLUMNS` is separated |
| )); | ||
| } | ||
|
|
||
| /** Renders a material-ui `GridTemplate` as a container. The |
There was a problem hiding this comment.
Ditto
Suggested change
| /** Renders a material-ui `GridTemplate` as a container. The | |
| /** Renders a `GridTemplate` as a container. The |
| * @param [schemaReadonly] - Optional flag indicating whether the schema indicates the field is readonly | ||
| * @param [forceReadonly] - Optional flag indicating whether the Form itself is in readonly mode | ||
| */ | ||
| export function computeFieldUiSchema<T = any, S extends StrictRJSFSchema = RJSFSchema, F extends FormContextType = any>( |
There was a problem hiding this comment.
Consider moving all the helper functions above the components that are using them...
| isReadonly, | ||
| optionsInfo, | ||
| fieldPathId: fieldIdSchema, | ||
| } = getSchemaDetailsForField<T, S, F>(registry, name, initialSchema, formData, fieldPathId); |
There was a problem hiding this comment.
Suggested change
| } = getSchemaDetailsForField<T, S, F>(registry, name, initialSchema, formData, fieldPathId); | |
| } = getSchemaDetailsForField<T, S, F>(registry, name, initialSchema, formData, fieldPathId); | |
| const memoFieldPathId = useDeepCompareMemo<FieldPathId>(fieldIdSchema); |
| schema={schema} | ||
| uiSchema={fieldUiSchema} | ||
| errorSchema={get(errorSchema, name)} | ||
| fieldPathId={fieldIdSchema} |
There was a problem hiding this comment.
Suggested change
| fieldPathId={fieldIdSchema} | |
| fieldPathId={memoFieldPathId} |
| return this.renderField(layoutGridSchema); | ||
| } | ||
| return <LayoutGridFieldComponent {...props} gridSchema={layoutGridSchema} />; | ||
| } |
There was a problem hiding this comment.
Since my company relies on the LayoutGridField.TEST_IDS variable, can you add the following? Plus that will simplify the tests since you can revert a bunch of changes:
Suggested change
| } | |
| } | |
| LayoutGridField.TEST_IDS = LAYOUT_GRID_FIELD_TEST_IDS; | |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasons for making this change
[Please describe them here]
If this is related to existing tickets, include links to them as well. Use the syntax
fixes #[issue number](ex:fixes #123).If your PR is non-trivial and you'd like to schedule a synchronous review, please add it to the weekly meeting agenda: https://docs.google.com/document/d/12PjTvv21k6LIky6bNQVnsplMLLnmEuypTLQF8a-8Wss/edit
Checklist
npx nx run-many --target=build --exclude=@rjsf/docs && npm run test:updateto update snapshots, if needed.