Fix committed offset is always less than log-end-offset by 1#634
Open
shamanu4 wants to merge 3 commits intorobinhood:masterfrom
Open
Fix committed offset is always less than log-end-offset by 1#634shamanu4 wants to merge 3 commits intorobinhood:masterfrom
shamanu4 wants to merge 3 commits intorobinhood:masterfrom
Conversation
Fix committed offset was always less than log-end-offset by 1
Author
|
Lint errors seem to be unrelated to this PR. |
|
I am facing this issue, need this fix! |
|
I'm also facing the same issue, need this fix |
Collaborator
|
Can you create this fix on the faust-streaming project? We can merge this to master and create a new release |
|
hey, any updates on that? we need it :-) |
Collaborator
|
This is already available in faust-streaming |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a bug, that committed offset is always less than log-end-offset in Kafka by 1 when all messages were processed. This bug causes 2 problems:
_drain_messagesfunction:if committed is None or offset > committed. )_drain_messagesfunction.This PR increases any committing offset by 1, so the log-end-offset will be equal to 0 when all messages are read.
Fixes #620