- 
                Notifications
    You must be signed in to change notification settings 
- Fork 247
Prometheus workload loader #266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from 1 commit
4fedd82
              c7ad1cd
              bf90978
              7cd0c59
              4044b4a
              b9a62a0
              7e8f1f4
              4c1f5c9
              7124c80
              d1ad17d
              f7d8412
              09c372b
              59cc29d
              d4adcf8
              eb84c95
              e350084
              d4e09b0
              7b6be35
              dce207f
              43ffb7f
              2403898
              73eb5f3
              24af7f5
              9fda8be
              f71abd1
              66389e6
              File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | 
|---|---|---|
|  | @@ -138,15 +138,16 @@ def run_strategy( | |
| ), | ||
| prometheus_cluster_label: Optional[str] = typer.Option( | ||
| None, | ||
| "--prometheus-cluster-label", | ||
| "--prometheus-cluster-value", | ||
| There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. same There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes, this one I did change but if I understand the runner code correctly, it uses  | ||
| "-l", | ||
| help="The label in prometheus for your cluster. (Only relevant for centralized prometheus)", | ||
| help="The name of the cluster in Prometheus to scan. e.g. 'gke-prod-1'. Use with `--prometheus-cluster-key`. Only relevant for centralized prometheus.", | ||
| rich_help_panel="Prometheus Settings", | ||
| ), | ||
| prometheus_label: str = typer.Option( | ||
| None, | ||
| "--prometheus-cluster-key", | ||
| "--prometheus-label", | ||
| help="The label in prometheus used to differentiate clusters. (Only relevant for centralized prometheus)", | ||
| help="The label in prometheus used to differentiate different clusters (e.g. 'cluster'). Only relevant for centralized prometheus.", | ||
| rich_help_panel="Prometheus Settings", | ||
| ), | ||
| eks_managed_prom: bool = typer.Option( | ||
|  | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aantn I think this requires a change on the robusta-runner as well
see here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@arikalon1 it should be fine. I'm not deprecating
--prometheus-label, just adding another option with a name that makes more sense.I did deprecate
--prometheus-cluster-labelbut the runner doesn't pass that by default.