-
Notifications
You must be signed in to change notification settings - Fork 78
fix: avoid deadlock on winsize signal #234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
* vxfw(Border): add BorderLabels to Border widget * - changed enum names to snake_case. - used Grapheme Iterator instead of old range based loop. - used `ctx.stringWidth()` instead of `text.len`. - added empty label guard. * modified loop to use stringWidth instead of i range * - Added trailing comma at the end of BorderLabel alignment enum definition. - Changed from `.width=1` to `.width=width` * - Added @intcast for width * fix zig fmt errors
This also fixes the vt example. Fixes: 58bc3fd ("deps: update zg")
Unicode is not actually used by Screen anyway, and Vaxis.init cannot return with Vaxis.screen.unicode assigned as the pointer to Vaxis.unicode could be dangling. The initial Vaxis without .screen.unicode makes {Window,widgets.View}.gwidth a footgun.
This prevents reporting kitty mouse leave events as spurious mouse clicks.
use an eventfd so than winsize event is sent from input thread
else => { | ||
if (!builtin.is_test) { | ||
if (self.winch_eventfd < 0) { | ||
self.winch_eventfd = try std.posix.eventfd(0, 0); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
eventfd
isn't available on macOS or the BSDs. This would need to move a .linux block
What is the deadlock you are getting? I don't think this is the correct approach given that it provides a very specific path for Linux only. But I want to understand what the actual problem is better before reviewing much more. |
use an eventfd so than winsize event is sent from input thread
fixes #218