Allow Usage of Custom Border Graphemes #236
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* vxfw(Border): add BorderLabels to Border widget * - changed enum names to snake_case. - used Grapheme Iterator instead of old range based loop. - used `ctx.stringWidth()` instead of `text.len`. - added empty label guard. * modified loop to use stringWidth instead of i range * - Added trailing comma at the end of BorderLabel alignment enum definition. - Changed from `.width=1` to `.width=width` * - Added @intcast for width * fix zig fmt errors
This also fixes the vt example. Fixes: 58bc3fd ("deps: update zg")
Unicode is not actually used by Screen anyway,
and Vaxis.init cannot return with Vaxis.screen.unicode assigned
as the pointer to Vaxis.unicode could be dangling.
The initial Vaxis without .screen.unicode
makes {Window,widgets.View}.gwidth a footgun.
This prevents reporting kitty mouse leave events as spurious mouse clicks.
- Allow user to specify type of border style. - Users can use 'bold', 'single', 'round', and other kinds of styles. - Make this change backwards-compatible.
- Use intuitive and recommended names.
- Use helper method to write graphemes in order to reduce repetition.
- Update example to use the new names.
- Update styles of displayed borders to showcase various features. - Document methods.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added the ability to use custom border graphemes to
vxfw.Border. Some commonly used borders such asbold,single,round(which was the one used internally), and many more, have been provided. The property for specifying graphemes (graphemes) was made optional and set toroundby default to ensure backward compatibility.I also added an example to the
examplesdirectory to showcase the border graphemes and other border attributes.