Don't use static to mark constexpr variables as link lokal#59
Open
autoantwort wants to merge 1 commit intorollbear:mainfrom
Open
Don't use static to mark constexpr variables as link lokal#59autoantwort wants to merge 1 commit intorollbear:mainfrom
autoantwort wants to merge 1 commit intorollbear:mainfrom
Conversation
Otherwise it is impossible to export types that depend on the strong_type since some of the used
templated values are link lokal. Error message from gcc:
out/build/x64-debug-linux/vcpkg_installed/x64-linux/include/strong_type/type.hpp:235:23: note: 'template<class ...> constexpr const bool strong::impl::always_false< <template-parameter-1-1>...>' declared with internal linkage
235 | static constexpr bool always_false = false;
| ^~~~~~~~~~~~
for something like
```c++
module;
#include <strong_type/strong_type.hpp>
export module test;
import std;
using myint = strong::type<int, struct my_int_>;
```
with gcc 15.2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Otherwise it is impossible to export types that depend on the strong_type since some of the used templated values are link lokal. Error message from gcc:
for something like
with gcc 15.2