Streaming rows with implied coordinates#599
Open
martinsp wants to merge 1 commit intoroo-rb:masterfrom
Open
Conversation
martinsp
pushed a commit
to itissible/roo
that referenced
this pull request
Sep 22, 2023
martinsp
pushed a commit
to itissible/roo
that referenced
this pull request
Sep 22, 2023
… #each_row_streaming
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Additional changes to #549. This avoids crash when using #each_streaming_row and
<c>elements inxl/worksheets/sheet<X>.xmldoes not haverattributeOther Information
This also changes signature for public method
Roo::Excelx::SheetDoc#each_celland adds optional argumentrow_index