-
Notifications
You must be signed in to change notification settings - Fork 84
$file.readBuffer to read the data from disk #343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
silverweed
merged 9 commits into
root-project:dev
from
Krmjn09:feature/deserializePage()-code
Jun 30, 2025
Merged
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
ffec80a
$file.readBuffer to read the data from disk
Krmjn09 f6dfc7b
Added rntuple_test.jsin .yml
Krmjn09 14cdddb
Added the simple.root
Krmjn09 ff2e659
uncommented the code
Krmjn09 13f45a5
removed warnings
Krmjn09 a46c75b
Column Validation
Krmjn09 c0068ba
simple method to pass simple.root
Krmjn09 f688edd
Calculating the uncompressed Size
Krmjn09 9a75e5f
suggeted changes
Krmjn09 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you using local
simple.root
file - please add it to PR, otherwise tests will failThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In fact, why did they not fail in the CI? Are the rntuple tests not run?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The tests in rntuple_test file are kind of like a checker for the fields and columns if they did not match for ntupl_staff001 it will answer like expected the first field as category but got doubles
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So the tests are running in my terminal but gives failure instead of Ok
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's passing all checks even if the simple.root is not in GitHub because I haven't still added rntuple_test.js in jsroot ci.yml file yet
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will do that as soon as possible