Skip to content

Conversation

Krmjn09
Copy link
Collaborator

@Krmjn09 Krmjn09 commented Jul 16, 2025

No description provided.

@Krmjn09 Krmjn09 changed the base branch from master to dev July 16, 2025 15:11
@Krmjn09 Krmjn09 requested review from linev and silverweed and removed request for silverweed July 16, 2025 15:11
Copy link
Contributor

@silverweed silverweed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, a couple of small comments

// Determine byte size per value based on column type
function getTypeByteSize(coltype) {
switch (coltype) {
case ENTupleColumnType.kReal64:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure this function can be very helpful later because some types have a size that's not an integer number of bits (e.g. Bit is 1 bit in size, Real32Trunc and Real32Quant have a variable bit length, etc).
For now it's fine to keep, but keep that in mind.

kByte: 4,
kChar: 5,
kBit: 6,
kReal64: 13,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please write these numbers in hexadecimal so they are more easily comparable with the BinarySpecification and the C++ version

@Krmjn09 Krmjn09 requested a review from silverweed July 17, 2025 07:26
@silverweed silverweed merged commit fde01ff into root-project:dev Jul 17, 2025
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants