Skip to content

Full Chain Graphic Testing with Headless Chrome Browser #16322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 18 commits into
base: master
Choose a base branch
from
Open

Full Chain Graphic Testing with Headless Chrome Browser #16322

Changes from 15 commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
34c17f8
Trigger test
DuesselbergAdrian Aug 28, 2024
e9ed872
Disabled new svg tests
DuesselbergAdrian Aug 29, 2024
a3dda1e
Testing root CI
DuesselbergAdrian Aug 29, 2024
026cb52
Installing chrome in ROOT CI
DuesselbergAdrian Aug 29, 2024
5bfea32
Disableing chrome in ROOT CI
DuesselbergAdrian Aug 30, 2024
cdb5bc3
Deleted ref files with small letters
DuesselbergAdrian Aug 30, 2024
e2e2ea5
Installing chrome on linux with Action
DuesselbergAdrian Sep 2, 2024
3f977bd
Chrome and homebrew installation on MAC
DuesselbergAdrian Sep 2, 2024
fe00330
Chrome and homebrew installation on MAC including sudo
DuesselbergAdrian Sep 2, 2024
560f013
Chrome instalations linux based platforms
DuesselbergAdrian Sep 3, 2024
275529b
Fedora 39 chrome installation
DuesselbergAdrian Sep 3, 2024
823228b
Remove sudo and test new svg only on linux
DuesselbergAdrian Sep 3, 2024
8740d90
chrome installation. enforcing bash
DuesselbergAdrian Sep 3, 2024
1ce631e
Reverted changes in build.py
DuesselbergAdrian Sep 12, 2024
ed25209
Chromium instead of google chrome installation
DuesselbergAdrian Sep 12, 2024
908aee3
Changed chromium installation for ubuntu
DuesselbergAdrian Sep 12, 2024
fd86e69
Adding snap to ubuntu chromium installation
DuesselbergAdrian Sep 12, 2024
abbb7b0
changing back to google chrome
DuesselbergAdrian Sep 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 32 additions & 0 deletions .github/workflows/root-ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,6 +121,22 @@ jobs:
with:
ref: ${{ inputs.ref_name }}

# TODO: Install chrome
# Latest error: sudo: a terminal is required to read the password; either use the -S option to read from standard input or configure an askpass helper
# sudo: a password is required
# Error: Process completed with exit code 1.
# - name: Install Homebrew
# run: |
# sudo /bin/bash -c "$(curl -fsSL https://raw.githubusercontent.com/Homebrew/install/HEAD/install.sh)"

# - name: Verify Installation
# run: |
# brew --version

# - name: Install chrome
# run: |
# brew install --cask google-chrome

- name: Apply option overrides from matrix for this job for non-release builds
if: ${{ github.event_name != 'schedule' && github.event_name != 'workflow_dispatch' && matrix.overrides != NaN }}
env:
Expand Down Expand Up @@ -414,6 +430,22 @@ jobs:
uses: actions/checkout@v4
with:
ref: ${{ inputs.ref_name }}

- name: Install Chromium
shell: bash
run: |
if [[ "${{ matrix.image }}" == "fedora39" ]]; then
dnf install -y chromium
elif [[ "${{ matrix.image }}" == "alma8" ]] || [[ "${{ matrix.image }}" == "alma9" ]] || [[ "${{ matrix.image }}" == "alma9-clang" ]]; then
dnf install -y epel-release
dnf install -y chromium
elif [[ "${{ matrix.image }}" == "ubuntu20" ]] || [[ "${{ matrix.image }}" == "ubuntu22" ]] || [[ "${{ matrix.image }}" == "ubuntu2404" ]]; then
apt update
apt install -y chromium-browser
elif [[ "${{ matrix.image }}" == "debian125" ]]; then
apt update
apt install -y chromium
fi

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why Google Chrome is used here? Why not to use chromium - it typically provided in all distributions.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok I'll change that

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the moment I see only installation of chromium - where it used then?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need it to run the new graphic svg test in roottest. root-project/roottest#1179

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see now. Does it works with roottest now?

Copy link
Contributor Author

@DuesselbergAdrian DuesselbergAdrian Sep 12, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For MAC the chrome/chromium installation is still missing. I think someone with authority has to do it.
The new svg tests with headless chrome browser are not hanging on MAC, at least on my machine. So after the installation it should be posisble to enabled all tests here.

For Linux the chromium installation is implemented, but here the headless browser is sometimes hanging.
That's why only 15 new svg tests are enabled. This is also the reason why I am currently differentiating between MAC and Linux platforms in my CMakeLists in roottest/graphics.

Yes in general there is a set of all test types, which is working on Linux and should also work on MAC after the chrome/chromium installation in the ROOT CI

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ill probably have to regenerate some references, but that's it.

- name: Dump GitHub context
env:
Expand Down
Loading