Enable CppInterOp #16814
Merged
Enable CppInterOp #16814
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronj0
force-pushed
the
enable-interop
branch
from
9392e07 to
2d038e7
Compare
Test Results 18 files 18 suites 4d 6h 46m 40s ⏱️ Results for commit 2887ee4. ♻️ This comment has been updated with latest results. |
hahnjo
requested changes
Nov 5, 2024
aaronj0
force-pushed
the
enable-interop
branch
2 times, most recently
from
ef871f9 to
86246a7
Compare
aaronj0
force-pushed
the
enable-interop
branch
2 times, most recently
from
196c4ff to
9977082
Compare
Closed
aaronj0
force-pushed
the
enable-interop
branch
3 times, most recently
from
ab52fd8 to
540c6fc
Compare
vgvassilev
reviewed
Dec 9, 2024
aaronj0
force-pushed
the
enable-interop
branch
2 times, most recently
from
c08b40e to
2a684e1
Compare
aaronj0
force-pushed
the
enable-interop
branch
from
93afacc to
b48a22e
Compare
vgvassilev
reviewed
Jan 7, 2025
aaronj0
force-pushed
the
enable-interop
branch
2 times, most recently
from
6f2ac11 to
7e53b7b
Compare
aaronj0
force-pushed
the
enable-interop
branch
10 times, most recently
from
eca5f31 to
8b5def2
Compare
aaronj0
force-pushed
the
enable-interop
branch
2 times, most recently
from
496960e to
08a79a9
Compare
hahnjo
approved these changes
Feb 18, 2025
|
@smuzaffar, can you check if cmssw works after this pr? |
To be honest, I don't really see why this is relevant to check: In this PR, CppInterOp is just added and not actually used... |
aaronj0
force-pushed
the
enable-interop
branch
4 times, most recently
from
3f0dbb6 to
755868a
Compare
by linking clangCppInterOp in libCling
aaronj0
force-pushed
the
enable-interop
branch
from
755868a to
2887ee4
Compare
I understand, and nevertheless I'd like to get a green light on this. |
|
cms tests are running here cms-sw#218 |
|
cmssw tests passed |
Thanks! |
vgvassilev
approved these changes
Feb 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CppInterOp exposes API from Clang and LLVM in a mostly backward compatibe way. The API support downstream tools that utilize interactive C++ by using the compiler as a service.
This PR is the first step in using pure clang based reflection API in meta, and part of eventually integrating the JITCall and DynamicLibraryManager infrastructure.
Adopting more of CppInterOp in ROOT will help simplify the LLVM migration process and allow us to upstream more patches to either CppInterOp or LLVM.
TODO:
builtin_llvm=offandbuiltin_clang=off