meta: Prevent memory hoarding for GetClass("int")
#18537
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 18 files 18 suites 4d 2h 39m 10s ⏱️ Results for commit f1f3538. ♻️ This comment has been updated with latest results. |
dpiparo
approved these changes
Apr 29, 2025
Member
dpiparo
left a comment
dpiparo
left a comment
There was a problem hiding this comment.
Thanks for this. We'll need also the backport for 6.36 ideally.
or any other numerical types.
This was referenced May 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevent memory hoarding for
GetClass("int")or any other numerical types.This addresses https://root-forum.cern.ch/t/repeatedly-mapping-branches-slowly-fills-memory/63412.
This fix #18536.
This relates to #9029 but does not solve it completely. It solves the sub-cases of #9029 where the typedef is known to
TROOT::GetListOfTypes.