[build] Protections for disabled geom and davix #18737
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ferdymercury
changed the title
ferdymercury
commented
May 15, 2025
pcanal
reviewed
May 15, 2025
pcanal
reviewed
May 15, 2025
| na49title->SetFillColor(32); | ||
| na49title->Draw(); | ||
| // | ||
| TFile *nageom = new TFile("na49.root"); |
Member
There was a problem hiding this comment.
Why is the test working in the regular case?
Collaborator
Author
There was a problem hiding this comment.
I think this file is created by na49geomfile.py <-- geometry.C <-- na49.C <-- na49geomfile.C
ferdymercury
commented
May 15, 2025
coherently with many other features.
See root-project#18736 [tutorial] protect no geom [cmake] veto tutorials in cmakelists rather than with preprocessor guards as hinted by pcanal
Test Results 18 files 18 suites 3d 6h 43m 14s ⏱️ For more details on these failures, see this check. Results for commit a2af93a. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building on top of the nice PR by dpiparo (#18639), I tried to add some more guards.
Fixes #18736