[CMake] CMake / include fixes for upcoming target-based CMake #19176
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hageboeck
requested review from
bellenot,
dpiparo,
lmoneta,
martamaja10,
pcanal and
vepadulano
as code owners
The GemmDerivative test was including TInterpreter without linking to Core. This will start to fail once automatic includes of everything will be removed in ROOT's CMake.
The test was including nlohmann/json, but RDF's dependency on nlohmann will be made private in subsequent commits. Consequently, this include might fail, but it's not used anyway.
gtest.h used to be parasitically included in TestSupport.hxx, which isn't using gtest at all. It's cleaner to include it where it is actually used.
TestSupport.hxx isn't using gtest, so it does not make sense to include it here.
According to the documentation, any OSX_SYSROOT needs to be set before the first project call. https://cmake.org/cmake/help/latest/variable/CMAKE_OSX_SYSROOT.html Since the setting came too late, homebrew compilers were missing the include list for homebrew compilers was generated wrongly.
hageboeck
force-pushed
the
target-basedCMake_part1
branch
from
bd0cff0 to
6c2aa67
Compare
|
Good that the failure on So new sporadic confirmed: |
Test Results 20 files 20 suites 3d 8h 44m 32s ⏱️ Results for commit 6c2aa67. ♻️ This comment has been updated with latest results. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are commits cherry-picked from #8709. These should be able to stand on their own, but they will be required for the upcoming changes in #8709.
Concretely, we have here:
OSX_SYSROOTbefore theproject()call as required in the CMake documentation