Update ROOT and Cling to LLVM20 #19242
Merged
+799,846
−386,111
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devajithvs
changed the title
Test Results 22 files 22 suites 4d 0h 9m 15s ⏱️ Results for commit 0204fdd. ♻️ This comment has been updated with latest results. |
2 tasks
This was referenced Jul 15, 2025
devajithvs
force-pushed
the
ROOT-llvm20
branch
2 times, most recently
from
9ee153a to
253faee
Compare
devajithvs
added
the
skip code analysis
devajithvs
force-pushed
the
ROOT-llvm20
branch
3 times, most recently
from
b01f14c to
d2749b8
Compare
devajithvs
force-pushed
the
ROOT-llvm20
branch
3 times, most recently
from
4e6fac4 to
1731a44
Compare
devajithvs
force-pushed
the
ROOT-llvm20
branch
4 times, most recently
from
67fd319 to
c090439
Compare
devajithvs
force-pushed
the
ROOT-llvm20
branch
from
c090439 to
818bfc3
Compare
devajithvs
requested review from
dpiparo,
pcanal and
vgvassilev
as code owners
|
@smuzaffar, the CI looks good and everything seems to be working reasonably well with the LLVM 20 upgrade. Could you check this PR against CMSSW? |
|
@devajithvs , cms-sw#227 is running cmssw CI tests for this change |
|
cmssw CI tests cms-sw#227 (comment) look good |
TemplateArgument can return a QualType that may contain unqualified parts. Before (incorrect): __gnu_cxx::__common_pool_policy<__pool, true> After (correct): __gnu_cxx::__common_pool_policy<__gnu_cxx::__pool, true>
LLVM 20 produce `RecoveryExpr` for dependent errors where LLVM 18 returned `ExprError`. In our type/name lookup path, this can leave a <recovery-expr> node and later codeGen asks the AST to constant-evaluate that initializer and we hit this assertion: `VarDecl::evaluateValueImpl: !Init->isValueDependent()`.
Avoid cases like: avoid `class__attribute__` with LLVM20 Fixes the failure on alma9: `gtest-tree-dataframe-dataframe-snapshot-emptyoutput`
Skip dumping TopLevelStmt if they are invalid. The change llvm/llvm-project@4b70d17bcf caused an invalid `TopLevelStatement` to be added to the AST, which can trigger assertions when dumping.
Also temporarily failing disable `testHashRecursiveRemove` test on Windows
template_arguments() has the types, but getTemplateArgs() has the pack argument, so their counts may be different. Add test for failing CMS build with LLVM 20. Co-authored-by: Devajith Valaparambil Sreeramaswamy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull request:
Update ROOT and Cling to LLVM20:
TODO:
Changes or fixes:
Checklist:
This PR fixes #