Skip to content

Conversation

bellenot
Copy link
Member

@bellenot bellenot commented Jul 7, 2025

Disable CppInterOp testing when there is no internet connection

Disable `CppInterOp testing` when there is no internet connection
@bellenot bellenot requested a review from aaronj0 July 7, 2025 12:06
@bellenot bellenot self-assigned this Jul 7, 2025
Copy link

github-actions bot commented Jul 7, 2025

Test Results

    21 files      21 suites   3d 7h 26m 44s ⏱️
 3 248 tests  3 248 ✅ 0 💤 0 ❌
66 478 runs  66 478 ✅ 0 💤 0 ❌

Results for commit 2367308.

♻️ This comment has been updated with latest results.

@bellenot bellenot requested a review from vgvassilev July 7, 2025 13:58
@hahnjo hahnjo self-requested a review August 5, 2025 09:17
Copy link
Member

@hahnjo hahnjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

interpreter/CppInterOp is supposed to be in sync with upstream. Can you move the code into "our" interpreter/CMakeLists.txt? We already have setup for CPPINTEROP_ENABLE_TESTING there...

@bellenot
Copy link
Member Author

bellenot commented Aug 5, 2025

interpreter/CppInterOp is supposed to be in sync with upstream. Can you move the code into "our" interpreter/CMakeLists.txt? We already have setup for CPPINTEROP_ENABLE_TESTING there...

Done

@bellenot bellenot requested a review from hahnjo August 5, 2025 10:46
Copy link
Member

@hahnjo hahnjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if it works; maybe squash the two commits when merging.

Copy link
Member

@vgvassilev vgvassilev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bellenot bellenot merged commit 5314202 into root-project:master Aug 5, 2025
26 checks passed
@bellenot bellenot deleted the fix-cppinterop-testing-no-internet branch August 5, 2025 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants