Skip to content

[nfc] consistent renaming of all buffersize variables #19610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Aug 13, 2025
Merged

[nfc] consistent renaming of all buffersize variables #19610

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
e5522a1
[nfc] consistent renaming of all buffersize variables
ferdymercury Aug 11, 2025
247ca6c
[nfc] fix typo
ferdymercury Aug 11, 2025
a7fde9e
Update core/base/src/TBuffer.cxx
pcanal Aug 11, 2025
822e00a
Update TFile.cxx
ferdymercury Aug 11, 2025
6cd0b8d
Update TFileCacheRead.cxx
ferdymercury Aug 11, 2025
241765a
Update hist/hist/src/TH1.cxx
pcanal Aug 11, 2025
cd3298f
Update hist/hist/src/TH1.cxx
ferdymercury Aug 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion core/base/src/TBuffer.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,8 +74,8 @@
{
if (bufsize < 0)
Fatal("TBuffer","Request to create a buffer with a negative size, likely due to an integer overflow: 0x%x for a max of 0x%x.", bufsize, kMaxBufferSize);
if (bufsize < kMinimalSize) bufsiz = kMinimalSize;
if (bufsize < kMinimalSize) bufsize = kMinimalSize;
fBufSize = bufsiz;

Check failure on line 78 in core/base/src/TBuffer.cxx

View workflow job for this annotation

GitHub Actions / alma9 march_native CMAKE_BUILD_TYPE=RelWithDebInfo, CMAKE_CXX_FLAGS=-march=native, CMAKE_C_FLAGS=-march=native, builtin_zlib=ON, builtin_zstd=ON 

‘bufsiz’ was not declared in this scope; did you mean ‘bufsize’?

Check failure on line 78 in core/base/src/TBuffer.cxx

View workflow job for this annotation

GitHub Actions / alma9 CMAKE_BUILD_TYPE=Debug 

‘bufsiz’ was not declared in this scope; did you mean ‘bufsize’?

Check failure on line 78 in core/base/src/TBuffer.cxx

View workflow job for this annotation

GitHub Actions / ubuntu2510 CMAKE_CXX_STANDARD=23 

‘bufsiz’ was not declared in this scope; did you mean ‘bufsize’?

Check failure on line 78 in core/base/src/TBuffer.cxx

View workflow job for this annotation

GitHub Actions / alma8 

‘bufsiz’ was not declared in this scope

Check failure on line 78 in core/base/src/TBuffer.cxx

View workflow job for this annotation

GitHub Actions / ubuntu22 imt=Off, CMAKE_BUILD_TYPE=Debug 

‘bufsiz’ was not declared in this scope; did you mean ‘bufsize’?

Check failure on line 78 in core/base/src/TBuffer.cxx

View workflow job for this annotation

GitHub Actions / debian125 CMAKE_CXX_STANDARD=20, dev=ON, CMAKE_CXX_FLAGS=-Wsuggest-override 

‘bufsiz’ was not declared in this scope; did you mean ‘bufsize’?

Check failure on line 78 in core/base/src/TBuffer.cxx

View workflow job for this annotation

GitHub Actions / alma9 modules_off runtime_cxxmodules=Off 

‘bufsiz’ was not declared in this scope; did you mean ‘bufsize’?

Check failure on line 78 in core/base/src/TBuffer.cxx

View workflow job for this annotation

GitHub Actions / ubuntu2404 CMAKE_BUILD_TYPE=Debug 

‘bufsiz’ was not declared in this scope; did you mean ‘bufsize’?

Check failure on line 78 in core/base/src/TBuffer.cxx

View workflow job for this annotation

GitHub Actions / fedora42 CMAKE_CXX_STANDARD=23 

‘bufsiz’ was not declared in this scope; did you mean ‘bufsize’?

Check failure on line 78 in core/base/src/TBuffer.cxx

View workflow job for this annotation

GitHub Actions / fedora43 CMAKE_CXX_STANDARD=23 

‘bufsiz’ was not declared in this scope; did you mean ‘bufsize’?

Check failure on line 78 in core/base/src/TBuffer.cxx

View workflow job for this annotation

GitHub Actions / alma10 

‘bufsiz’ was not declared in this scope; did you mean ‘bufsize’?

Check failure on line 78 in core/base/src/TBuffer.cxx

View workflow job for this annotation

GitHub Actions / mac15 ARM64 CMAKE_CXX_STANDARD=23 

use of undeclared identifier 'bufsiz'; did you mean 'bufsize'?

Check failure on line 78 in core/base/src/TBuffer.cxx

View workflow job for this annotation

GitHub Actions / ubuntu2504 CMAKE_CXX_STANDARD=23 

‘bufsiz’ was not declared in this scope; did you mean ‘bufsize’?

Check failure on line 78 in core/base/src/TBuffer.cxx

View workflow job for this annotation

GitHub Actions / alma10 clang Ninja CMAKE_C_COMPILER=clang, CMAKE_CXX_COMPILER=clang++ 

use of undeclared identifier 'bufsiz'; did you mean 'bufsize'?

Check failure on line 78 in core/base/src/TBuffer.cxx

View workflow job for this annotation

GitHub Actions / rawhide Fedora pydebug CMAKE_CXX_STANDARD=23 

‘bufsiz’ was not declared in this scope; did you mean ‘bufsize’?
fMode = mode;
fVersion = 0;
fParent = nullptr;
Expand Down
Loading