Skip to content

Conversation

silverweed
Copy link
Contributor

@silverweed silverweed commented Sep 16, 2025

Add a bunch of functions to poke through the abstraction of the storage classes (specifically, to get the underlying TDirectory and RMiniFileReader). These functionalities (all Internal) will be needed by the RNTuple Attributes (see the full PR for details)

Checklist:

  • tested changes locally
  • updated the docs (if necessary)

Copy link

Test Results

    18 files      18 suites   3d 1h 53m 51s ⏱️
 3 668 tests  3 403 ✅   0 💤 265 ❌
64 527 runs  63 925 ✅ 335 💤 267 ❌

For more details on these failures, see this check.

Results for commit 20cba70.

Copy link
Contributor

@jblomer jblomer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we really need GetUnderlyingDirectory()? Since the attribute anchor is a hidden key, we can just store it in the ROOT file's root directory.

@silverweed
Copy link
Contributor Author

Do we really need GetUnderlyingDirectory()? Since the attribute anchor is a hidden key, we can just store it in the ROOT file's root directory.

Not sure...the reason I need it in the full PR is to create the AttrSetWriter which then uses it create a PageSinkFile using it. Even if we wanted to store the key in the root directory we'd still need the underlying TFile for it...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants