[RF] Expose again interface to write NLL codegen debug macro #20001
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These custom pullbacks and pushforwards have the wrong signature so they were not used anyway. The inline implementations of `TMath::Min()` and `TMath::Max()` use the C++ ternary operator, which Clad can handle now. So these user derivatives are also not needed anymore.
This experimental public interface was so far implemented in the `RooFuncWrapper` class, but it got lost from the public interface when that class was merged into the implementation details of the `RooEvaluatorWrapper` (in commit 5b9d51d). Writing the codegen debug macros is however quite useful for developing, so this commit brings back that functionality as a free function in the `RooFit::Experimental` namespace.
Test Results 22 files 22 suites 3d 20h 32m 34s ⏱️ Results for commit bd6c3f2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This experimental public interface was so far implemented in the
RooFuncWrapperclass, but it got lost from the public interface whenthat class was merged into the implementation details of the
RooEvaluatorWrapper(in commit 5b9d51d).Writing the codegen debug macros is however quite useful for developing,
so this commit brings back that functionality as a free function in the
RooFit::Experimentalnamespace.